feat: change post-cleanup default to false#272
Merged
Conversation
pavelzw
reviewed
Jun 29, 2026
Collaborator
|
i'm wondering whether we should also run the logout step always 🤔 wdyt? |
Hofer-Julian
force-pushed
the
push-plwrlppwovru
branch
from
f5b6f99 to
b9b18ef
Compare
Contributor
Author
Done! |
Contributor
Author
Yes, I think so. Let's do that in a follow-up PR though |
Especially on Windows this sometimes goes wrong. On other platforms it also often doesn't make sense since runners are ephemeral. Disabling that might even speed things up
Hofer-Julian
force-pushed
the
push-plwrlppwovru
branch
from
b9b18ef to
199e440
Compare
pavelzw
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially on Windows this sometimes goes wrong.
On other platforms it also often doesn't make sense since runners are ephemeral. Disabling that might even speed things up
If updating documentation: